Post cantina #357
Merged
Post cantina #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Update `post-cantina`
Add comment duplicate markets in maxDeposit/Mint
Remove outdated comment
StErMi
reviewed
Dec 30, 2023
StErMi
reviewed
Dec 30, 2023
StErMi
reviewed
Dec 30, 2023
StErMi
reviewed
Dec 30, 2023
StErMi
reviewed
Dec 30, 2023
Signed-off-by: Quentin Garchery <[email protected]>
Delete pending cap when removing a market
…e-metamorpho into fix/stermi-review
Co-authored-by: MathisGD <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
post-cantina#349 : Fix : moves natspec to interfaces.Owner()function was not marked as view.reallocatefunction natspec to help not revert.marketParamsinstead ofid_withdraw()maxDeposit()reallocatefunction.submitMarketRemoval(add comments about the purpose of this mechanism).maxDeposit()andmaxMint()functions because of duplicate markets in the supply queue.updateWithdrawQueue#371 : Acknowledge that the reallocating funds might give unexpected results